FIX parsing for Long in scientific notation#673
Closed
ilmirons wants to merge 2 commits intotypelevel:mainfrom
Closed
FIX parsing for Long in scientific notation#673ilmirons wants to merge 2 commits intotypelevel:mainfrom
ilmirons wants to merge 2 commits intotypelevel:mainfrom
Conversation
FIX parsing for Long numbers in scientific notation
Author
|
Closing as #674 includes this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I noticed DeferNum uses
parseLongUnsafeto parse number strings in scientific notation format, which seems not to be correct. I don't know if this is a performance choice (I get converting withn.toLongmay be slower), but shouldn't at that point throw immediately be a better option? I wrote some tests and swappedparseLongUnsafe(s)withn.toLong. Give it a look when you have time.Thanks for the great work,
Andrea