fix: remove zero-length segments in simplifyPath#366
Open
BuckyQ wants to merge 1 commit into
Open
Conversation
…ines Duplicate consecutive points in a trace path create zero-length segments that appear as extra trace lines in the post-processing step (issue tscircuit#78). The previous simplifyPath only collapsed collinear midpoints but did not handle the case where p1 === p2 (identical coordinates). Adding a dedupConsecutive pass before each collinear-collapse pass ensures all zero-length stubs are removed before rendering. /claim tscircuit#78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78
/claim #78
Root Cause
simplifyPathcollapsed collinear midpoints but did not remove duplicate consecutive points (zero-length segments). Adjacent path points with identical coordinates produce a zero-length stub that renders as an extra trace line in the schematic.Fix
Added
dedupConsecutiveto strip identical adjacent points before each collinear-collapse pass.simplifyPathnow runscollapseCollinear(dedupConsecutive(path))twice, with a finaldedupConsecutivepass.Tests
8 new unit tests: duplicate in middle, at start, at end, multiple consecutive duplicates, collinear collapse (H and V), zero-length stub at direction change.
Full suite: 65 pass, 4 skip, 0 fail. Format + type check pass.