Make Dispatch generic over buffer size and release v0.3.0#16
Merged
robin-nitrokey merged 3 commits intomainfrom Mar 25, 2025
Merged
Make Dispatch generic over buffer size and release v0.3.0#16robin-nitrokey merged 3 commits intomainfrom
robin-nitrokey merged 3 commits intomainfrom
Conversation
This fixes a new compiler warning.
The fixed buffer size can be problematic for some use cases, see: - #15 To avoid adding support for different buffer sizes to the crate, we can just make the dispatch implementation generic over the buffer size. For simple cases, a type alias is provided using the old buffer size.
This release makes Dispatch generic over the buffer size.
This was referenced Mar 21, 2025
sosthene-nitrokey
approved these changes
Mar 24, 2025
daringer
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed buffer size can be problematic for some use cases, see:
To avoid adding support for different buffer sizes to the crate, we can
just make the dispatch implementation generic over the buffer size. For
simple cases, a type alias is provided using the old buffer size.