Teach #from_hash to raise TypeError when argument is not a Hash#203
Open
myabc wants to merge 3 commits intotrailblazer:masterfrom
Open
Teach #from_hash to raise TypeError when argument is not a Hash#203myabc wants to merge 3 commits intotrailblazer:masterfrom
myabc wants to merge 3 commits intotrailblazer:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@apotonick An alternative would be for
#from_hashto fail silently (i.e.data = {} unless ::Hash === data). However, I think raising aTypeErrormakes more sense in a web application context. it allows theOperationor web framework Controller to rescueTypeErrorand return a400to the client.