Conversation
|
This is hilarious! From what I have seen so far the pr looks good, but now Also I don't think I can remotely verify if
is correct, but I'll take it :D |
|
It would still write the number in english with everything around it localized. (if it's breaking anyway, I might add localization to it now) Maybe a And for the correctness, while I doubt anyone would unironically say centillillion, https://bignumbers.fandom.com/wiki/Millillion shows, that this is somewhat used/recognized. And for more normal numbers, it matches the Wikipedia list. |
|
I tried and concluded, that localizing that is infeasible, even german is quite some effort, and I have no idea how you would do something like french for example. Instead, I would maybe add a warning for non Also noticed: We could make Correction: localization basically means a fully new algorithm each time. So it is way lower on priority of localization |
Yeah I would welcome a clearer calculation -> result -> formatting pipeline. But this doesn't have to be done in the PR here |
tolik518
left a comment
There was a problem hiding this comment.
Also please add a test in integration.rs for behavior with different languages. This would be a good documentation for what would happen in that case
…them fix factorion_math::length of negative numbers (use abs) add write_out for ApproximateDigits add write_out for ComplexInfinity add minus and zero support to write_out_number fix spelling of forty
|
In addition to the fixes, asked additions, I added support for negative numbers and writing out the number of digits. |
|
Great! Thank you! I'll start the merge train! |
DEPENDS ON #326(Merged)This adds the ability to write out numbers up to 9.9999999...*10^3000000.
It only writes out the most significant parts.
This is a breaking change in the library as the arguments for
formatchange. To combat this in the future and make the signature less cluttered, I added aFormatOptionsstruct.This is also only in english, as of this point. There would be a lot to add to locale, otherwise.
Resolves #150