Improved fix for #12, extends pullreq #16: fix babel support issues#20
Open
GerHobbelt wants to merge 2 commits intotj:masterfrom
Open
Improved fix for #12, extends pullreq #16: fix babel support issues#20GerHobbelt wants to merge 2 commits intotj:masterfrom
GerHobbelt wants to merge 2 commits intotj:masterfrom
Conversation
…when babel has transpiled all `assert(...)` calls to something else (`(0, _.default)(...)` for example), we look for that transpiled code instead. (assuming Babel 7) Defensive coding ensures no crash when these assumptions don't match reality: instead of the function arguments, '???' is reported instead. - Completely removed obsolete callsite references in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for babel 7. Augments #16, fixes #12.
See fork https://github.com/GerHobbelt/better-assert for
npm testtests including babel transpiled runs.The key problem was when using a modern
import assert from ...statement in your code, which is then transpiled by babel, which replaces theassert(...)calls which something like(0, _.default)(...)when you transpile to ES5 or similar old targets, resulting in the/assert\(.../line regex in better-assert to crash.See also the pullreqqed code changes and commit message.