Open
Conversation
Author
|
Any review? |
Member
|
I don't have the expertise to review this. But ... have you tested this sufficiently? How much testing have you done on this? |
Author
|
I tested many times and published several papers with this fix. |
Member
|
Not able to test but I will chat with you on Skype to go through the change one by one and then approve. Lets do it this week. |
Author
|
Ok. When is good for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have evaluated TinyRPL for some years and found out some bugs, which cause malfunction.
This pull request is simply reporting these bugs.
So, we should replace "BLIP_L2_RETRIES" to BLIP_L2_RETRIES*divideRank for fairness.