✨ Widen variable types on reassignment via LUB#121
Merged
Conversation
The analyser now tracks type changes when a variable is reassigned by computing the LUB of the old and new types and updating the binding. This fixes false "not declared" errors when destructuring a variable that was initialized as () and later reassigned to a tuple. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
timfennis
force-pushed
the
feature/reject-incompatible-reassignment
branch
from
ee39b2f to
c7db1a6
Compare
timfennis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
()and later reassigned to a tuple (e.g.let pos = (); pos = (1, 2); let a, b = pos;)Test plan
bug0015verifies the original bug is fixedcargo clippyandcargo fmtclean🤖 Generated with Claude Code