Add RBAC for the new ui-apis ManagedCluster / ClusterInformation handlers#4798
Open
Brian-McM wants to merge 1 commit into
Open
Add RBAC for the new ui-apis ManagedCluster / ClusterInformation handlers#4798Brian-McM wants to merge 1 commit into
Brian-McM wants to merge 1 commit into
Conversation
…lers The cloud security fix in calico-private (PR #11546) moves UISettings delete, ManagedCluster CRUD, and ClusterInformation reads off the user-impersonated /apis/projectcalico.org/v3 proxy path and onto ui-apis handlers that call the Calico API with their own service-account token. The tigera-manager pod SA therefore needs new grants on these resources. Changes to managerClusterRole (pkg/render/manager.go): - uisettings / uisettingsgroups / uisettingsgroups/data — add "delete" (previously only get/list/watch). - managedclusters — add "create" and "delete" verbs (previously only get/list/watch). "update" continues to live in managedClustersUpdateRBAC(). - clusterinformations — new rule with "get" and "list" so the UI can surface the management cluster version through ui-apis. manager_test.go updated at both assertion sites to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cloud security fix in calico-private (PR #11546) moves UISettings delete, ManagedCluster CRUD, and ClusterInformation reads off the user-impersonated /apis/projectcalico.org/v3 proxy path and onto ui-apis handlers that call the Calico API with their own service-account token. The tigera-manager pod SA therefore needs new grants on these resources.
Changes to managerClusterRole (pkg/render/manager.go):
manager_test.go updated at both assertion sites to match.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.