Wrap list2 usage in make_contructor()#6797
Merged
teunbrand merged 1 commit intotidyverse:rc/4.0.2from Feb 2, 2026
Merged
Conversation
teunbrand
added a commit
that referenced
this pull request
Feb 4, 2026
* polish news * reorder a few bullets in news * prep for release * don't bother subsetting labels (#6745) * Increment version number to 4.0.1 * explicitly wrap `list2` (#6797) * polish news * retroactively note `base_size` change (#6795) * update cran-comments.md * Increment version number to 4.0.2 * Increment version number to 4.0.2.9000 --------- Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
teunbrand
added a commit
that referenced
this pull request
Apr 22, 2026
* polish news * reorder a few bullets in news * prep for release * don't bother subsetting labels (#6745) * Increment version number to 4.0.1 * explicitly wrap `list2` (#6797) * polish news * retroactively note `base_size` change (#6795) * update cran-comments.md * Increment version number to 4.0.2 * Fix snapshot test for `warn_dots_used()` * Update Kapa.ai settings to be more privacy friendly (#6823) * Fix logical error and typo in FAQ Customising vignette (#6809) - Correct reference to colour aesthetic instead of fill - Fix typo ("which what" → "which is what") Fixes #6805 * add stats:: in front of stats functions that were not explicitly imported (#6793) * add stats:: in front of stats functions that were not explicitly imported * use `vec_ave()` * do not use `vec_slice()` for the key before computing hash * anticipate S3 text element (#6848) * Replace `stats::ave()` (#6698) * use vctrs-variant of `stats::ave()` * replace other instances of `stats::ave()` too * polish news * Allow choosing quantile definition in boxplots (#6820) * update: geom_boxplot to add quantile type argument * update: change quantile_type to quantile.type * update: NEWS.md * update: document() * tiny doc polish * Extra words for news * update cran comments * revdepcheck * update comments with revdepcheck * Increment version number to 4.0.3 * Increment version number to 4.0.3.9000 --------- Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com> Co-authored-by: Lionel Henry <lionel.hry@proton.me> Co-authored-by: Julia Silge <julia.silge@gmail.com> Co-authored-by: Ashish Tiwari <152683981+ashishtiwari03@users.noreply.github.com> Co-authored-by: klin333 <klin441@gmail.com> Co-authored-by: David Muñoz Tord <david.munoztord@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6796.
It prevents attach
rlang::list2()as a variable direclty. I've tested the built time dependency by building ggplot2 with rlang 1.1.6, upgrading to rlang 1.1.7 and seeing if there are warnings when using the fruits ofmake_contructor(). There were no longer such warnings. Note PR targets the rc/4.0.2 branch, not the main branch.