Skip to content

Fix: server.js no longer exposes server & development files#144

Open
cameronhum wants to merge 1 commit intothoth-tech:mainfrom
cameronhum:fix-static-file-exposure
Open

Fix: server.js no longer exposes server & development files#144
cameronhum wants to merge 1 commit intothoth-tech:mainfrom
cameronhum:fix-static-file-exposure

Conversation

@cameronhum
Copy link
Copy Markdown
Contributor

Description

server side files such as server.js and package.json were being exposed to the web. This fix moved all necessary web files to a public folder and requires server.js to declare extra directories that are not inside the public folder so nothing is unintentionally exposed. This follows a better security standard whilst maintaining the current flow and functionality of the app.

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants