Skip to content

Add MGIS_HAVE_TFEL compile definitions with enable-static#216

Closed
Briffou wants to merge 1 commit intothelfer:masterfrom
Briffou:master
Closed

Add MGIS_HAVE_TFEL compile definitions with enable-static#216
Briffou wants to merge 1 commit intothelfer:masterfrom
Briffou:master

Conversation

@Briffou
Copy link

@Briffou Briffou commented Feb 13, 2026

I think this definition is missing with enable-static

@thelfer
Copy link
Owner

thelfer commented Feb 13, 2026

@Briffou Thanks for this PR. However, if I am not mistaken, this correction is already in master:

if(MGIS_HAVE_TFEL)
  target_compile_definitions(MFrontGenericInterface PUBLIC MGIS_HAVE_TFEL)
  target_link_libraries(MFrontGenericInterface PUBLIC tfel::TFELMath tfel::TFELMFrontDatabase)
  if(enable-static)                                                                                                                                    
    target_compile_definitions(MFrontGenericInterface-static PUBLIC MGIS_HAVE_TFEL)
    if(TARGET tfel::TFELMath-static)                                                                
      target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMath-static)
    else()
      target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMath)
    endif()
    if(TARGET tfel::TFELMFrontDatabase-static)                                                                
      target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMFrontDatabase-static)                                                
    else()
      target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMFrontDatabase)                                              
    endif()
  endif(enable-static) 
endif(MGIS_HAVE_TFEL)

Focus in particular on those lines:

  if(enable-static)                                                                                                                                    
    target_compile_definitions(MFrontGenericInterface-static PUBLIC MGIS_HAVE_TFEL)

Do I miss something ?

@Briffou
Copy link
Author

Briffou commented Feb 13, 2026

Oh sorry, you are right ! I was getting a failure with spack (with version 3.1.0 of MGIS) but didn't even take the time to check master 😞

While waiting for a new version of MGIS with the fix, I will force master branch of MGIS in spack in the meantime.

Thanks !

@Briffou Briffou closed this Feb 13, 2026
@thelfer
Copy link
Owner

thelfer commented Feb 13, 2026

@Briffou You may want to use rliv-3.1 instead, which is far more stable than master, as it only contains bug fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants