Add MGIS_HAVE_TFEL compile definitions with enable-static#216
Closed
Briffou wants to merge 1 commit intothelfer:masterfrom
Closed
Add MGIS_HAVE_TFEL compile definitions with enable-static#216Briffou wants to merge 1 commit intothelfer:masterfrom
Briffou wants to merge 1 commit intothelfer:masterfrom
Conversation
Owner
|
@Briffou Thanks for this PR. However, if I am not mistaken, this correction is already in if(MGIS_HAVE_TFEL)
target_compile_definitions(MFrontGenericInterface PUBLIC MGIS_HAVE_TFEL)
target_link_libraries(MFrontGenericInterface PUBLIC tfel::TFELMath tfel::TFELMFrontDatabase)
if(enable-static)
target_compile_definitions(MFrontGenericInterface-static PUBLIC MGIS_HAVE_TFEL)
if(TARGET tfel::TFELMath-static)
target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMath-static)
else()
target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMath)
endif()
if(TARGET tfel::TFELMFrontDatabase-static)
target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMFrontDatabase-static)
else()
target_link_libraries(MFrontGenericInterface-static PUBLIC tfel::TFELMFrontDatabase)
endif()
endif(enable-static)
endif(MGIS_HAVE_TFEL)Focus in particular on those lines: if(enable-static)
target_compile_definitions(MFrontGenericInterface-static PUBLIC MGIS_HAVE_TFEL)Do I miss something ? |
Author
|
Oh sorry, you are right ! I was getting a failure with spack (with version 3.1.0 of MGIS) but didn't even take the time to check master 😞 While waiting for a new version of MGIS with the fix, I will force master branch of MGIS in spack in the meantime. Thanks ! |
Owner
|
@Briffou You may want to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this definition is missing with
enable-static