feat: improve DX of the CI #317
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for the-codegen-project canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const symbol = this.colorsEnabled ? pc.green('✓') : '[OK]'; | ||
| console.log(`${symbol} ${displayText}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Spinner text fallback lost after stopSpinner nullifies spinner
Medium Severity
In succeedSpinner and failSpinner, calling this.stopSpinner() sets this.spinner = null before the code tries to access this.spinner?.text as a fallback. The fallback expression text || this.spinner?.text || '' will always resolve to an empty string when text is not provided, since this.spinner is already null at that point. The spinner text should be captured before calling stopSpinner().
Additional Locations (1)
| process.stdout.cursorTo(0); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Spinner never resumes after pause due to missing null assignment
Medium Severity
In pauseSpinner(), after calling clearInterval(this.spinner.interval), the interval property still holds the old interval ID (a truthy number). The resumeSpinner() method checks !this.spinner.interval to decide whether to restart the spinner, but this condition will always be false since the interval ID is still present. This causes the spinner animation to freeze permanently after any log message is output in TTY mode.
Note
Improves CLI UX, error handling, and generator outputs across the codebase.
Loggerwith levels, colors, spinners, JSON output; introducesBaseCommandwith verbosity/JSON/color flags and updatesgenerate,init, andtelemetryto use itCodegenError) and replaces ad-hoc throws with typed, user-friendly errors across configs, parsers (AsyncAPI/OpenAPI/JSON Schema), and TS generatorsGenerationResult/GeneratorResultwithfilesWrittenand durations; watch mode and success output reflect thispicocolors)Written by Cursor Bugbot for commit 9bac4a3. This will update automatically on new commits. Configure here.