Fix macOS click-through for transparent shaped windows#4
Open
iman-zamani wants to merge 1 commit intotexus:masterfrom
Open
Fix macOS click-through for transparent shaped windows#4iman-zamani wants to merge 1 commit intotexus:masterfrom
iman-zamani wants to merge 1 commit intotexus:masterfrom
Conversation
Replaced static hit-testing with a dynamic 60Hz NSTimer that checks mouse position. It updates [NSWindow setIgnoresMouseEvents:] based on the image's alpha channel, allowing clicks to pass through transparent pixels to underlying applications.
Owner
|
The goal of this project is to serve as a simple example. This change more than doubles the amount of code in Transparent.mm and makes it more complicated to follow. If the existing code didn't allow mouse clicks to pass to the windows behind it, then I do consider your code to be useful. So maybe if you e.g. store your modified file as a Gist then this project can mention the limitation and link to that gist? |
Contributor
Author
|
Fair point! Feel free to close this out. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced static hit-testing with a dynamic 60Hz NSTimer that checks mouse position. It updates [NSWindow setIgnoresMouseEvents:] based on the image's alpha channel, allowing clicks to pass through transparent pixels to underlying applications.