Option to disable checkstyle in tmc-netbeans

[avihavai]

Provides configuration support for disabling checkstyle runs in tmc-netbeans.

[avihavai]

This is related to the issue #101

[mpartel]

What's the difference between DISABLED and NONE?

[avihavai]

No difference, in some cases none is already used. How does this work if the existing projects have none in some cases and disabled in other cases?

[mpartel]

Should we get rid of one of them then?

[kasper]

I feel this duplicates existing behaviour, but at least I would not suggest on creating a new undocumented strategy. See https://github.com/testmycode/tmc-checkstyle-runner#options.

[avihavai]

I'm ok with ditching either disabled or none. If the strategy is not found, how is it handled?

kasper: do you mean this pull request or the option?

[kasper]

@avihavai Indeed, this is the issue. Currently tmc-checkstyle-runner is responsible for reading the configuration and adjusting its behaviour accordingly.

Personally, I would make it possible to ask the configuration from tmc-checkstyle-runner. It currently takes care of deciding the strategy and if it should be run or not. Alternatively, you could move this task completely to this project and the pass the option to the runner. Then again, it would be rather tied to this Netbeans-plugin since the idea is that the runner can be used independently.

[jamo]

Any updates on this?

[avihavai]

This is still somewhat relevant. However, I think that the larger issue is that the related dependencies are downloaded with each assignment to the user, making the downloads relatively large at times. I think that we should aim for excluding the dependencies from the download when they are not used or needed. Perhaps something for the legacy project?

[jamo]

Yep, we shouldn't add unused deps to the project zips when these are generated. However first we need to make sure that the client works w/o having these files.

I might put this on hold till we have first deployed version of NB plugin with tmc-core.