fix: Set nullable types in operation classes/interfaces#74
fix: Set nullable types in operation classes/interfaces#74HofmeisterAn merged 11 commits intotestcontainers:mainfrom
Conversation
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have two quick questions.
Some operation interfaces still use ... CancellationToken cancellationToken);. Probably something we should align too?
1504220 to
209db97
Compare
I have fixed them. There were just 3 in the interfaces and two of them are actually obsolete. |
|
Also some interfaces are implemented explicitly and others are not. If you want I can also make them consistent (either way). |
If we change it, it would be great to align and make it consistent (as long as it's not too much work). I don't think there's a need to implement them explicitly? |
All Operations interfaces are now implemented implicitly. |
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks for all the effort. I slightly polished the changes and made them more consistent. If you're okay with the updates, I'm happy to merge the PR. Thanks again!
…d of ServiceUnavailable
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks 🙏.
You've contributed a lot recently, so I wanted to give you a quick update on what I'm planning to work on next for Docker.DotNet. My goal is to refactor the API (operation interfaces) to support multiple Docker Engine APIs to support the API downgrade feature, along with ongoing cleanups.
I'm not entirely sure how to approach this yet. For now, I'm thinking of introducing a new API alongside the existing one and transitioning to the new API over time. This also include better auto-generated model classes and interfaces (specgen) to streamline development (probably without netstandard support).
Some parameters can be
nulllikeso the parameters should be marked as nullable
Also replaced
default(CancellationToken)withdefaultfor consistency.Changes only affect *Operations interfaces / classes.