-
Notifications
You must be signed in to change notification settings - Fork 0
all checkpoints should throw LeaseExpired when applicable #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
reviewed
Jan 30, 2026
Aaron1011
reviewed
Jan 30, 2026
e315639 to
7d82aa4
Compare
Aaron1011
reviewed
Jan 30, 2026
Aaron1011
approved these changes
Jan 30, 2026
GabrielBianconi
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not failing tasks when their lease had expired at the time they are writing checkpoints. We now throw a control error when a task attempts to write a checkpoint with an expired lease.
Note
Medium Risk
Changes core Postgres lease/checkpoint functions and worker control-flow handling; mistakes could cause unexpected task termination or lock contention under concurrency.
Overview
Checkpoints/heartbeats now enforce active leases.
durable.set_task_checkpoint_stateanddurable.extend_claimwere updated to lock intask -> runorder and to validate that the run is stillrunningwith an unexpiredclaim_expires_at; if not, they raise SQLSTATEAB002(added via a new migration).Runtime behavior changes. Rust adds
ControlFlow::LeaseExpired(mapped fromAB002) and the worker treats it as non-fatal control flow (logs and stops without double-failing the run). Tests addSleepThenCheckpointTaskplus new lease-expiry cases asserting no checkpoints are written after lease expiry; benches add hierarchical parent/child/grandchild tasks for stress testing.Written by Cursor Bugbot for commit 1f82eb7. This will update automatically on new commits. Configure here.