Skip to content

Conversation

@yycptt
Copy link
Member

@yycptt yycptt commented Dec 30, 2025

What changed?

  • Add panic wrapper for library logic
  • Also provides a logger through the Context interface

Why?

  • Capture panic error so that it's easier to tell where the panic actually happens. Otherwise a panic can cause another panic in some unrelated deferred function making debugging harder.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@yycptt yycptt marked this pull request as ready for review December 31, 2025 22:38
@yycptt yycptt requested review from a team as code owners December 31, 2025 22:38
}

// TODO: Deprecate following logging methods and use ms.logger directly.
func (ms *MutableStateImpl) logInfo(msg string, tags ...tag.Tag) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup on these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants