[WIP]Add centrally managed TLS configuration for console-plugin nginx#3218
Open
jkhelil wants to merge 1 commit intotektoncd:mainfrom
Open
[WIP]Add centrally managed TLS configuration for console-plugin nginx#3218jkhelil wants to merge 1 commit intotektoncd:mainfrom
jkhelil wants to merge 1 commit intotektoncd:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the console-plugin nginx server to inherit TLS settings from the centrally managed APIServer TLS Profile for Post-Quantum Cryptography (PQC) readiness compliance.
Changes
Modified:
pkg/reconciler/openshift/tektonconfig/console_plugin_reconciler.goTLS_MIN_VERSION,TLS_CIPHER_SUITES,TLS_CURVE_PREFERENCES)Modified:
pkg/reconciler/openshift/tektonconfig/console_plugin_reconciler_test.goTest Results
Test 1: Default Configuration (No Env Vars)
Environment:
Generated nginx.conf:
Result: ✅ Pod starts successfully, TLS 1.3 negotiated, no errors
Test 2: With TLS Environment Variables
Environment:
Generated nginx.conf:
Result: ✅ Pod starts successfully, TLS 1.3 negotiated, curves applied, no errors
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes