Add NewSeleniumServiceV4 to support cli args for selenium version 4

[Prendo93]

Selenium V3 seems to now be considered legacy (https://www.selenium.dev/documentation/legacy/selenium_3/). This PR adds NewSeleniumServiceV4 which sets up the service using the new format for v4. During my (admittedly limited) testing it seems to work as a drop-in replacement for Selenium V3 implementation.

[ChristianSch]

Would it be possible to merge this? @minusnine

[minusnine]

Please add a documentation comment.

https://github.com/golang/go/wiki/CodeReviewComments#doc-comments

[minusnine]

selenium_test.go needs to be updated to test Selenium v4:

selenium/selenium_test.go

Line 22 in e9100b7

selenium3Path = flag.String("selenium3_path", "", "The path to the Selenium 3 server JAR. If empty or the file is not present, Firefox tests using Selenium 3 will not be run.")

selenium/selenium_test.go

Line 131 in e9100b7

t.Run("Selenium3", func(t *testing.T) {

selenium/selenium_test.go

Line 161 in e9100b7

} else {

selenium/selenium_test.go

Line 196 in e9100b7

t.Run("Selenium3", func(t *testing.T) {

selenium/selenium_test.go

Line 227 in e9100b7

SeleniumVersion: semver.MustParse("3.0.0"),

selenium/selenium_test.go

Line 284 in e9100b7

s, err = selenium.NewSeleniumService(webDriverPath, port, c.ServiceOptions...)

We should also add Selenium v4 to be automatically downloaded by vendor/init.go:

selenium/vendor/init.go

Line 63 in e9100b7

url: "https://selenium-release.storage.googleapis.com/3.141/selenium-server-standalone-3.141.59.jar",

[ChristianSch]

I'm also not sure that this is correct. The PR uses /wd/hub as the urlPrefix (which is a suffix btw), which doesn't seem to be used by selenium 4:

GET http://localhost:4444/wd/hub
-> 
{
  "value": {
    "error": "unknown command",
    "message": "Unable to find handler for (GET) \u002fwd\u002fhub",
    "stacktrace": ""
  }
}

(same for POST)

@Prendo93 did this actually work for you?

[Prendo93]

Can confirm this is working for me with https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.1.0/selenium-server-4.1.1.jar

I think the urlPrefix is named thus because there are other routes called, eg: /wd/hub/session etc.

[ChristianSch]

Hm, ok. Do you specify a prefix? Or do you omit it? Would you mind posting a quick example where it's running for you? Would help tremendously!

Edit: it actually does work! It just doesn't work with the selenium standalone docker images for some reason.