test(install): add e2e test for env peer deps after bit create#10218
Merged
davidfirst merged 3 commits intomasterfrom Mar 9, 2026
Merged
test(install): add e2e test for env peer deps after bit create#10218davidfirst merged 3 commits intomasterfrom
davidfirst merged 3 commits intomasterfrom
Conversation
Verifies that env peer dependencies (e.g., @types/react) are properly installed when creating a react component, and that check-types passes. Covers the fix from PR #10215.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new end-to-end regression test to ensure env peer dependencies (notably @types/react) are installed correctly for a newly created React component, covering the fix from #10215.
Changes:
- Introduces a new e2e test that runs
bit create reactand validates env peer deps are present innode_modules. - Adds a
bit check-typesassertion to ensure type-checking works after creation.
You can also share your feedback on Copilot code review. Take the survey.
Remove describe.only, fix stale describe title, use runCmd instead of runWithTryCatch for stronger assertion.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
GiladShoham
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an e2e test that verifies env peer dependencies (e.g.,
@types/react) are properly installed when runningbit create react. The test creates a react component using the default bitdev env and asserts that@types/reactis present innode_modulesandbit check-typespasses without errors.Covers the fix from #10215.