Skip to content

feat: add inject_nexus_repo.sh to inject Nexus mirror repo#159

Merged
feici02 merged 6 commits intomainfrom
feat/inject-nexus-repo
Apr 11, 2026
Merged

feat: add inject_nexus_repo.sh to inject Nexus mirror repo#159
feici02 merged 6 commits intomainfrom
feat/inject-nexus-repo

Conversation

@jiajingbin
Copy link
Copy Markdown
Contributor

Description

Add inject_nexus_repo.sh to inject Nexus mirror repo

Issue(s)

https://project.feishu.cn/taosdata_td/job/detail/6954254328

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the inject_nexus_repo.sh script, which automates the configuration of Nexus mirror repositories for various Linux distributions, including Ubuntu, Debian, CentOS, Kylin, and openEuler. The script auto-detects the operating system and sets up the corresponding RPM or DEB repository files. Feedback focuses on preventing script failure in the _field function due to pipefail, implementing a root privilege check for system modifications, and enhancing the robustness of yum.conf parsing to correctly handle whitespace variations.

Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh Outdated
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a standalone Bash utility to configure an OS package manager (APT/YUM) to use a Nexus-hosted mirror, intended for offline-environment preparation.

Changes:

  • Introduces .github/scripts/offline_env/inject_nexus_repo.sh to auto-detect OS/version and write Nexus repo configuration for RPM/DEB systems.
  • Implements OS-specific Nexus path mappings for ubuntu/debian/centos/kylin/openeuler.
  • Disables existing upstream repos/sources after injecting Nexus configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 10, 2026 16:23
jiajingbin and others added 2 commits April 11, 2026 00:26
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh
Comment thread .github/scripts/offline_env/inject_nexus_repo.sh Outdated
Copy link
Copy Markdown
Member

@feici02 feici02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feici02 feici02 merged commit 174124a into main Apr 11, 2026
@feici02 feici02 deleted the feat/inject-nexus-repo branch April 11, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants