Search for USB cams in RoboConUSBCamera instead of just assuming /dev/video0#41
Open
scorbett123 wants to merge 4 commits intosystemetric:masterfrom
Open
Search for USB cams in RoboConUSBCamera instead of just assuming /dev/video0#41scorbett123 wants to merge 4 commits intosystemetric:masterfrom
scorbett123 wants to merge 4 commits intosystemetric:masterfrom
Conversation
shardros
reviewed
Nov 10, 2022
Co-authored-by: Skyler <skyler3665@gmail.com>
Minion3665
reviewed
Nov 10, 2022
Member
Minion3665
left a comment
Minion3665
left a comment
There was a problem hiding this comment.
I've made suggestions that together will dynamically get the number of the camera rather than needing to hardcode video0 and video1 (as well as checking for a USB camera rather than against a pi camera).
Please check them over and commit them if you feel they add value @scorbett123
search all of /dev/videoX Check whether a camera is a USB cam instead of not being a pi cam Co-authored-by: Skyler <skyler3665@gmail.com>
Forgot this Co-authored-by: Skyler <skyler3665@gmail.com>
Minion3665
approved these changes
Nov 10, 2022
Member
Minion3665
left a comment
Minion3665
left a comment
There was a problem hiding this comment.
Looks good to me and seems to work. Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of https://hydrosysblog.wordpress.com/2018/10/31/rpi-check-if-dev-videon-is-picam-or-usb-camera/