ec/ite: Move e-flash signature to 0x80 #554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
dev/eflash-sig
branch
from
a9ed964 to
0d5146b
Compare
Member
|
@crawfxrd will this work on all currently supported ITE ECs? |
Member
Author
|
Presumably. I tested it works on IT5570 (darp10-b). I don't have a IT8587 board, but it should work on those older boards as well. I'm doing some testing now and adding more documentation for the "known" bits. |
jackpot51
previously approved these changes
Jan 20, 2026
crawfxrd
force-pushed
the
dev/eflash-sig
branch
from
0d5146b to
0cb691f
Compare
According to the datasheet, the e-flash signature can be at any 16-byte aligned address in 0x40-0xF0. Because of an address conflict with SDCC 4.5.0, move the signature to 0x80. This matches the address for Zephyr RISC-V SoCs, like 82302. Ref: zephyrproject-rtos/zephyr#36379 Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
dev/eflash-sig
branch
from
0cb691f to
288cfda
Compare
jackpot51
approved these changes
Jan 20, 2026
Member
Author
|
Must be checked on an IT8587 board. 32k clock selection changed from external crystal to internal clock generator. There's no clock source connected to GPJ6/7 on any board and they're all configured as GPIO and not ALT function, so I don't think it would even work. I guess there's no issue because nothing is actually using the 32 kHz clock? (Proprietary firmware also has it set to use external crystal.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the datasheet, the e-flash signature can be at any 16-byte aligned address in 0x40-0xF0. Because of an address conflict with SDCC 4.5.0, move the signature to 0x80. This matches the address for Zephyr RISC-V SoCs, like 82302.
Ref: zephyrproject-rtos/zephyr#36379
Resolves: #518