Skip to content

CI: Add Clang Static Analyzer#28

Merged
jserv merged 1 commit intomainfrom
static-analysis
Mar 7, 2026
Merged

CI: Add Clang Static Analyzer#28
jserv merged 1 commit intomainfrom
static-analysis

Conversation

@jserv
Copy link
Contributor

@jserv jserv commented Mar 7, 2026

This integrates scan-build into GitHub Actions:

  • Standard checkers as a blocking gate (--status-bugs)
  • Alpha checkers as non-blocking informational reporting
  • Extract setup_llvm_repo() in install-deps.sh to share LLVM 20 APT repository setup between format and analysis modes
  • Upload HTML scan-build reports as artifacts on failure

Summary by cubic

Adds Clang Static Analyzer (scan-build) to CI as a blocking check, with alpha checkers reported as non-blocking; includes small const-correctness and safety fixes uncovered by analysis.

  • New Features

    • Adds static-analysis job to GitHub Actions (Ubuntu 24.04) using scan-build-20 with --status-bugs.
    • Runs alpha checkers as informational and posts a notice with counts.
    • Uploads HTML scan-build reports as artifacts on failure.
    • Extends .ci/install-deps.sh with analysis mode and shared setup_llvm_repo() for LLVM 20.
  • Bug Fixes

    • Corrects word-left cursor movement in text fields (uses the right previous index).
    • Sets side sheet elevation to IUI_ELEVATION_2 when modal.
    • Const-correct APIs and internals (e.g., iui_table_end, nav_end, bottom_sheet_end, bottom_app_bar; headless framebuffer size; various tests).
    • Introduces IUI_ASSERT to avoid Clang Analyzer false positives while keeping debug asserts.
    • Minor cleanups: tighter variable scopes, const arrays, static linkage for internal helpers.

Written for commit 9889ddf. Summary will update on new commits.

This integrates scan-build into GitHub Actions:
- Standard checkers as a blocking gate (--status-bugs)
- Alpha checkers as non-blocking informational reporting
- Extract setup_llvm_repo() in install-deps.sh to share LLVM 20
  APT repository setup between format and analysis modes
- Upload HTML scan-build reports as artifacts on failure
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

@jserv jserv merged commit 7efb2a4 into main Mar 7, 2026
13 checks passed
@jserv jserv deleted the static-analysis branch March 7, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant