Skip to content

refactor: lift hideBalance state to parent composable #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvsena42 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

refactor: lift hideBalance state to parent composable #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/src/main/java/to/bitkit/ui/screens/wallets/activity/ActivityDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ fun ActivityDetailScreen(
is ActivityDetailViewModel.ActivityLoadState.Success -> {
val item = loadState.activity
val app = appViewModel ?: return@Box
val settings = settingsViewModel ?: return@Box
val hideBalance by settings.hideBalance.collectAsStateWithLifecycle()
val copyToastTitle = stringResource(R.string.common__copied)

val tags by detailViewModel.tags.collectAsStateWithLifecycle()
Expand Down Expand Up @@ -237,6 +239,7 @@ fun ActivityDetailScreen(
description = text.ellipsisMiddle(40)
)
},
hideBalance = hideBalance,
feeRates = feeRates,
)
if (showAddTagSheet) {
Expand Down Expand Up @@ -316,11 +319,9 @@ private fun ActivityDetailContent(
isCpfpChild: Boolean = false,
boostTxDoesExist: Map<String, Boolean> = emptyMap(),
onCopy: (String) -> Unit,
hideBalance: Boolean = false,
feeRates: FeeRates? = null,
) {
val settings = settingsViewModel ?: return
val hideBalance by settings.hideBalance.collectAsStateWithLifecycle()

val isLightning = item is Activity.Lightning
val isSent = item.isSent()
val isTransfer = item.isTransfer()
Expand Down
Loading