Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jan 29, 2026

Fixes #732

This PR fixes monetary values not being hidden on the activity detail page when the user has enabled balance hiding.

Description

When users swipe to hide their balance, values are hidden throughout the app (home page, confetti sheet, activity list) but the individual activity detail page still displayed bitcoin and fiat amounts. This PR:

  1. Enables the swipe-to-hide gesture on the balance header in activity detail
  2. Hides the payment amount and fee values when balance hiding is active

Preview

Screen_recording_20260129_131012.webm
Screen_recording_20260129_131210.webm

QA Notes

1. Activity detail with hidden balance

  1. Open the wallet
  2. Swipe on the balance to hide it
  3. Tap on any activity in the list
  4. Verify the header balance shows • • • • • • • • •
  5. Verify the payment amount shows • • • • •
  6. Verify the fee amount shows • • • • • (if applicable)

2. Swipe to toggle on activity detail

  1. With balance visible, tap on an activity
  2. Swipe on the balance header to hide
  3. Verify all monetary values are hidden
  4. Swipe again to show
  5. Verify all values are visible again

3. Regression - Balance visible

  1. Ensure balance is visible (not hidden)
  2. Tap on any activity
  3. Verify all amounts display correctly with proper currency formatting

@jvsena42 jvsena42 self-assigned this Jan 29, 2026
@jvsena42 jvsena42 requested a review from ovitrif January 29, 2026 16:18
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude's comments do seem relevant, otherwise LGTM 🥂

@ovitrif ovitrif merged commit 5c57306 into master Jan 30, 2026
20 checks passed
@ovitrif ovitrif deleted the fix/hide-activity-detail-balance branch January 30, 2026 03:53
@jvsena42
Copy link
Member Author

Claude's comments do seem relevant

agreed, hadn't seen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monetary values not hidden in activity page

3 participants