Conversation
|
Thanks @valtzu, I like that proposal - and I'd skip the cc @OskarStark @fabpot WDYT? |
|
Sounds like a good and flexible approach |
|
I like it a lot! |
|
@valtzu can you finish this one? |
|
@OskarStark Sorry I was afk the whole Easter; I'll try Thanks all for comments |
c2b9e17 to
ffa33ae
Compare
|
Ok I think I may have taken a too big bite here. I'm struggling quite much on how to glue results & contents. It could be easier to start from the lower layer (in a separate PR) and add some |
After #1900 this could be adjusted to use |
ffa33ae to
a90024f
Compare
AssistantMessage & ContentInterfaceAssistantMessage
I tried this (pushed here) – it mostly works, but one of the issues is that as result objects contain raw results ( Still somehow using |
|
yeah, having second thoughts as well. i agree that new AssistantMessage(
new Thinking('foo', 'bar'),
new Text('Hello'),
new ToolCall('id1', 'function1', ['param1' => 'value1']),
new new ToolCall('id2', 'function2', ['param2' => 'value2']),
), |
|
i think that´s great and i like it! |
Rework
AssistantMessageto better model the APIs andthoughtSignaturesLooking for feedback before proceeding further as this change is quite enormous at this late stage
Before
After