[Concurrency] Make leaks testing use the leaks macos tool#88375
[Concurrency] Make leaks testing use the leaks macos tool#88375ktoso wants to merge 2 commits intoswiftlang:mainfrom
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
mikeash
left a comment
There was a problem hiding this comment.
Looks good, although it's unfortunate to lose coverage on other platforms. In practice there shouldn't be any cross-platform variation that would cause a leak only on some other platform.
|
Yeah, unfortunately not great drop in equivalent on the other platforms 😢 We could make something but that'd be more work... Thanks for review |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test macOS platform |
|
Turns out this gets stuck on CI, likely due to leaks needing more permissions hm... Looking into it some more |
This is more reliable than the deinit printing which often is flaky when CI is slow etc. Resolves rdar://174207235
|
@swift-ci please smoke test |
|
Nope, this also doesn't work on CI. |
|
We may need to give up on |
This is more reliable than the deinit printing which often is flaky when CI is slow etc.
Resolves rdar://174207235
Outputs are rather nice as well:
And if we actually have a leak:
etc