jextract: Move Foundation support into a common package with code generation#687
Open
sidepelican wants to merge 20 commits intoswiftlang:mainfrom
Open
jextract: Move Foundation support into a common package with code generation#687sidepelican wants to merge 20 commits intoswiftlang:mainfrom
sidepelican wants to merge 20 commits intoswiftlang:mainfrom
Conversation
sidepelican
commented
Apr 8, 2026
Comment on lines
+98
to
+100
| if !group.value.allSatisfy({ $0.value.swiftNominal.moduleName == "SwiftRuntimeFunctions" }) { | ||
| printer.print("import SwiftRuntimeFunctions") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
A workaround to ensure the generated code doesn't import its own package
| return renderFoundationDataThunks(nominal) | ||
| default: | ||
| return [] | ||
| if nominal.swiftNominal.moduleName == "SwiftRuntimeFunctions" { |
Contributor
Author
There was a problem hiding this comment.
Foundation types are now imported using the swift-java package name. This is the concern I raised in #684 (comment)
Contributor
Author
|
The license check is showing an error for the generated code, but why |
Contributor
Author
|
I found |
Collaborator
|
I'm reviewing this but need more time, probably tomorrow. Thanks for poking at this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #684.
For Foundation types, this PR uses jextract generated code instead of manual implementation.
This approach continues to use
printSpecificTypeHelpersin the code generator.