Skip to content

Android 6.3 support #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcprux wants to merge 6 commits into
base: main
Choose a base branch
from
+3 −3
Open

Android 6.3 support #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86235b2
Update android_sdk_versions to include 6.3
marcprux Mar 25, 2026
93773ab
Fix selector for android-sdk in releases.json
marcprux Mar 25, 2026
49199a9
Update comment
marcprux Mar 25, 2026
86cfc46
Add debugging output
marcprux Mar 25, 2026
260fb39
Remove debugging output
marcprux Mar 25, 2026
f6062c1
Merge branch 'swiftlang:main' into android-6.3
marcprux Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/scripts/install-and-build-with-sdk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ command -v jq >/dev/null || install_package jq
SWIFT_API_INSTALL_ROOT="https://www.swift.org/api/v1/install"

# Transforms a minor Swift release version into its latest patch version
# and gets the checksum for the patch version's Static Linux and/or Wasm Swift SDK.
# and gets the checksum for the patch version's Android, Static Linux, or Wasm Swift SDK.
#
# $1 (string): A minor Swift version, e.g. "6.1"
# Output: A string of the form "<patch-version>|<android-checksum>|<static-checksum>|<static-version>|<wasm-checksum>
Expand Down Expand Up @@ -233,7 +233,7 @@ find_latest_swift_version() {
.[]
| select(.name == $version)
| .platforms[]
| select(.platform == "android")
| select(.platform == "android-sdk")
| .checksum
')

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/swift_package_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ on:
android_sdk_versions:
type: string
description: "Android Swift SDK version list (JSON)"
default: "[\"nightly-main\", \"nightly-6.3\"]"
default: "[\"nightly-main\", \"nightly-6.3\", \"6.3\"]"
Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove nightly-6.3 by default? I don't see it adding value for most devs.

Copy link
Copy Markdown
Contributor Author

@marcprux marcprux Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following Static Linux precedent:

github-workflows/.github/workflows/swift_package_test.yml

Lines 57 to 60 in 61db691

linux_static_sdk_versions:
type: string
description: "Static Linux Swift SDK version list (JSON)"
default: "[\"nightly-main\", \"nightly-6.2\", \"6.2\"]"

I don't know if it adds value for devs, but it might add value for us so we can more quickly identify any regressions that may come with the 6.3 nightlies.

I can go either way with it. WDYT, @shahmishal?

Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's even worse: no way static linux SDK users still want the old last 6.2 nightly snapshot built against, a complete waste.

We really need to prune that default version list for all platforms, starting with nightly-6.3 for Android in this pull. The others we can do in another pull, once the reviewers chime in on what they want.

Copy link
Copy Markdown
Contributor Author

@marcprux marcprux Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's even worse: no way static linux SDK users still want the old last 6.2 nightly snapshot built against, a complete waste.

Well, I'm guessing that they just haven't updated it for 6.3 yet.

Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those 6.2 nightlies should have been dropped once 6.2 was tagged or soon after.

Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I neglected to mention that there will likely be few 6.3 nightlies going forward, eg there were only a couple dozen 6.2 nightly snapshots after 6.2 was tagged last fall, stopping completely after Dec. 3.

Copy link
Copy Markdown
Contributor Author

@marcprux marcprux Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter much to me, but each of the other SDKs are tested against each of the three versions: nightly-main, nightly-x.y, and x.y. Are we just concerned about resource utilization? What is the harm of testing against nightly-6.3?

I'm happy to go with whatever @shahmishal and @swiftlang/github-workflows-contributors recommend, but I would like to start testing against 6.3 as soon as possible.

Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter much to me, but each of the other SDKs are tested against each of the three versions: nightly-main, nightly-x.y, and x.y.

That makes perfect sense most of the year, as the two snapshot branches are being actively worked on, and we of course want the current release tested. There is a month or two window each year though, when a new minor release like 6.3 is tagged and the nightly-6.x snapshots for that branch are phased out, where their value is questionable.

Are we just concerned about resource utilization? What is the harm of testing against nightly-6.3?

Yes, wasting resources is the main concern, but not the only one. Right now, we would be testing packages against the 6.3 tag and a 3-week older commit from the same release/6.3 branch, which makes no sense.

How long we keep the 6.3 snapshot branch active as a default is debatable, based on how many new snapshots we expect going forward and how important we think it is to test those, which is why I phrased this originally as a question. If you as the Android release manager don't want to decide, I'm fine with the others you pinged deciding.

Copy link
Copy Markdown
Contributor Author

@marcprux marcprux Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, we would be testing packages against the 6.3 tag and a 3-week older commit from the same release/6.3 branch […]

Good point on that, but hopefully we will get some new build soon that surpasses the 6.3 release tag.

My main concern is that we not get blindsided by a regression creeping into 6.3.1, which is what nightly-6.3 will help us exercise once the nightly-6.3 snapshots move forward.

If you as the Android release manager don't want to decide, I'm fine with the others you pinged deciding.

I think it is reasonable to keep Android's default testing matrix consistent with the other SDKs.

Copy link
Copy Markdown
Member

@finagolfin finagolfin Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, up to you, I will only raise the matter again once the 6.3 nightlies are stopped.

android_exclude_swift_versions:
type: string
description: "Exclude Android Swift SDK version list (JSON)"
Expand Down
Loading