-
Notifications
You must be signed in to change notification settings - Fork 1
best practice template for ESG #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
heckj
wants to merge
3
commits into
swiftlang:main
Choose a base branch
from
heckj:practice-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| # ``EcosystemTools`` | ||
|
|
||
| ## Topics | ||
|
|
||
| - <doc:best-practices> |
63 changes: 63 additions & 0 deletions
63
...ystem-tools/Sources/EcosystemTools.docc/best-practices/best-practice-content.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # Contribute a Swift Server best practice for internal adopters | ||
|
|
||
| Create clear guidance with examples for best practice documentation. | ||
|
|
||
| ## Overview | ||
|
|
||
| A best practice article provides practical advice from experienced Swift practitioners, solving common problems, or providing support to others doing the same. | ||
| These articles use a specific naming scheme to enable consistent URLs when they're published, so that those URLs can be referenced, or shared, from a variety of places. | ||
|
|
||
| ### Create a guidance article | ||
|
|
||
| Use the [template provided in the Ecosystem docs repository](https://github.com/swiftlang/docs/blob/main/ecosystem-tools/templates/0000-best-practice-template.md) to create guidance. | ||
| Use a numbered filename to contain the content. | ||
| Prefix guidelines from the ecosystem group with `ESG-` and using the next number available. | ||
| When published with DocC, the filename of the article becomes a component in the URL and provides a consistent reference point. | ||
| Don't rename an existing article, or re-use a number from other guides that have been merged. | ||
|
|
||
| ### Create an a title and abstract for the article | ||
|
|
||
| Provide a title and abstract that provides a high level, skimmable overview of the guidance. | ||
| The title should by a high level summary, and the abstract should work with the title to provide additional detail on where or how the guidance applies. | ||
|
|
||
| ### Make an overview | ||
|
|
||
| Add an explicit `## Overview` section to provide an a concise introduction that cuts to the heart of the guidance and why it's important. The overview should: | ||
| - Identify the problem this guide solves, or what issues it avoids. | ||
| - Provide a concise summary (one to three sentences, not a paragraph or more) of why the problem is an issue and what benefits you get following the guidance. | ||
| - Identify the scope of the guidance: how or where it pertains, if the guidance isn't generally applicable. | ||
|
|
||
| ### Provide an example of the guidance | ||
|
|
||
| Add a section header with an imperative title that provides the guidance. | ||
| Prefix the content with a green sphere (🟢), which uses a stop-light metaphor, so the reader can easily visually identify the preferred guidance. | ||
|
|
||
| Provide code examples that illustrate the guidance, using DocC's snippets feature to ensure that the example compiles: | ||
|
|
||
| - For anything other than trivial code examples, create and use a snippet Swift file to verify that code samples compile. | ||
| - To use a snippet, create a Swift file in the Snippets directory and reference the snippet in this template. | ||
| - Reference the snippet in the best practice using the @Snippet directive. For example, if you create a snippet file named `ESG-0005.swift` in the Snippets directory, use the directive reference: `@Snippet(path: "EcosystemTools/Snippets/ESG-0005")` | ||
|
|
||
| ### Share alternatives considered | ||
|
|
||
| Add the section `### Alternatives Considered` for a section to highlight lessor guidance. | ||
| For example, to illustrate patterns that work but aren't ideal, or express anti-patterns to avoid. | ||
| Any additional content in this section should provide detail as to why the pattern is suboptimal or one to avoid. | ||
|
|
||
| - Use a yellow sphere (🟠) to highlight suboptimal advice or patterns that may be required, but is not as good a solution as the primary guidance. | ||
|
|
||
| - Use a red sphere (🛑) to highlight antipatterns or specifics to avoid. | ||
|
|
||
| ### Identify the recency and applicability of the article | ||
|
|
||
| At that bottom of the document, include a "History" section to share relevant to specific versions of swift, and recen | ||
| cy of the guidance. | ||
| The following example shows a history block last updated in March, 2026 and with content relevant to Swift 6.0 or earlier: | ||
|
|
||
| ``` | ||
| ### History | ||
|
|
||
| | Last updated | Swift Versions | | ||
| | ---- | ---- | | ||
| | March 2026 | Swift >= 6.0+ | | ||
| ``` |
9 changes: 9 additions & 0 deletions
9
ecosystem-tools/Sources/EcosystemTools.docc/best-practices/best-practices.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Guidelines and Best Practices | ||
|
|
||
| ## Overview | ||
|
|
||
| ## Topics | ||
|
|
||
| ### Reviews | ||
|
|
||
| - <doc:best-practice-content> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # (ESG-0000) best practice title | ||
|
|
||
| <!-- | ||
| - Use H1 header for the title, leading with the prefix and number of the best practice, then provide a concise title describing the best practice. | ||
|
|
||
| - name the markdown file with a prefix and number (example ESG-0004) to ensure consistent URL presentation when merged into a DocC Catlog. | ||
| - Once approved, ***never rename***, only deprecate or remove. | ||
| --> | ||
|
|
||
| {{ Replace with a single sentence abstract that describes what the best practice covers and expands upon title. }} | ||
|
|
||
| ## Overview | ||
|
|
||
| 🟢 - lead sentence details the core of what the good practice is. The overview in general should be concise and to the point. | ||
|
|
||
| Extend the overview with an additional paragraph providing more background if needed, preferring to link to external specifications, documentation, etc as needed instead of providing it inline. | ||
|
|
||
| <!-- DEPRECATION: | ||
| - If a best practice is no longer valid | ||
| - update the title to include (DEPRECATED) | ||
| - add into the overview where to go for updated best practice that replaces the prior advice, and (if relevant) what versions of Swift are suggested where the updated/new advice applies. | ||
| - Put the redirect in a WARNING aside at the top of the overview | ||
| - Move deprecated advice to the bottom of any curation/organization list of practices | ||
| --> | ||
|
|
||
| ### Example | ||
|
|
||
| Provide a clear, complete, ideally "real" example of the best practice. If describing an API pattern, show both the implementation side and "call site" usage to illustrate it. | ||
|
|
||
| If there's supporting tasks for the best practice, include the specifics of how to enable them in further H3 sections. Write The H3 section headings as imperative verb phrases that describe what the example is showing and what you should do for the best practice. | ||
|
|
||
| <!-- Use Snippets to verify code examples: | ||
| - For anything other than trivial code examples, create and use a snippet Swift file to verify that code samples compile. | ||
| - To use a snippet, create a Swift file in the Snippets directory and reference the snippet in this template. | ||
| - Reference the snippet in the best practice using the @Snippet directive. For example, if you create a snippet file named `ESG-0005.swift` in the Snippets directory, use the directive reference: | ||
| `@Snippet(path: "EcosystemTools/Snippets/ESG-0005")` | ||
| --> | ||
|
|
||
| ## Alternatives Considered | ||
|
|
||
| Lead with a 🟠 yellow/orange stoplight emoji to indicate alternates with tradeoffs. Explain when/why you might need to fall back and not use the best practice. | ||
|
|
||
| Lead with a 🔴 red stoplight emoji to indicate an anti-pattern and what not to do. Explain why or the impact of not following the best practice. | ||
|
|
||
| ## History | ||
|
|
||
| <!-- | ||
| - include last updated (month/year), should be updated if the practice is edited | ||
| - Swift revision applicable - identify what versions of Swift this applies to as well | ||
| --> | ||
|
|
||
| | Last updated | Swift Versions | | ||
| | ---- | ---- | | ||
| | February 2026 | Swift >= 6.0+ | | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.