Skip to content

chore(sv): bump ESLint to v10 and update related dependencies #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jycouet wants to merge 3 commits into
base: main
Choose a base branch
from
+250 −311
Open

chore(sv): bump ESLint to v10 and update related dependencies #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7d7339
chore: bump ESLint to v10 and update related dependencies
jycouet Mar 14, 2026
3ee6037
chore: add changeset for ESLint v10 bump
jycouet Mar 15, 2026
0fddff1
refactor(sv): remove unused form property from Sverdle demo page props
jycouet Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-shrimps-hunt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

chore(sv): bump ESLint to v10 and update related dependencies
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
"devDependencies": {
"@changesets/cli": "^2.29.8",
"@playwright/test": "^1.58.1",
"@sveltejs/eslint-config": "^8.3.4",
"@sveltejs/eslint-config": "^9.0.0",
"@svitejs/changesets-changelog-github-compact": "^1.2.0",
"@trivago/prettier-plugin-sort-imports": "^6.0.2",
"@types/node": "^20.19.30",
"@typescript/native-preview": "7.0.0-dev.20251212.1",
"@vitest/ui": "4.1.0",
"eslint": "^9.39.2",
"eslint-plugin-svelte": "^3.14.0",
"eslint": "^10.0.3",
"eslint-plugin-svelte": "^3.15.2",
"magic-string": "^0.30.21",
"prettier": "^3.8.1",
"prettier-plugin-packagejson": "^2.5.22",
Expand All @@ -38,7 +38,7 @@
"svelte": "^5.53.0",
"tsdown": "^0.18.4",
"typescript": "^5.9.3",
"typescript-eslint": "^8.54.0",
"typescript-eslint": "^8.57.0",
"vitest": "4.1.0"
},
"packageManager": "pnpm@10.17.0"
Expand Down
12 changes: 6 additions & 6 deletions packages/sv/src/addons/eslint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ export default defineAddon({
const typescript = language === 'ts';
const prettierInstalled = Boolean(dependencyVersion('prettier'));

sv.devDependency('eslint', '^9.39.2');
sv.devDependency('@eslint/compat', '^2.0.2');
sv.devDependency('eslint-plugin-svelte', '^3.14.0');
sv.devDependency('globals', '^17.3.0');
sv.devDependency('@eslint/js', '^9.39.2');
sv.devDependency('eslint', '^10.0.3');
sv.devDependency('@eslint/compat', '^2.0.3');
sv.devDependency('eslint-plugin-svelte', '^3.15.2');
sv.devDependency('globals', '^17.4.0');
sv.devDependency('@eslint/js', '^10.0.1');
sv.devDependency('@types/node', getNodeTypesVersion());

if (typescript) sv.devDependency('typescript-eslint', '^8.54.0');
if (typescript) sv.devDependency('typescript-eslint', '^8.57.0');

if (prettierInstalled) sv.devDependency('eslint-config-prettier', '^10.1.8');

Expand Down
12 changes: 6 additions & 6 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
},
"devDependencies": {
"@better-auth/cli": "~1.4.21",
"@eslint/compat": "^2.0.2",
"@eslint/js": "^9.39.2",
"@eslint/compat": "^2.0.3",
"@eslint/js": "^10.0.1",
"@inlang/paraglide-js": "^2.10.0",
"@libsql/client": "^0.17.0",
"@playwright/test": "^1.58.2",
Expand All @@ -38,10 +38,10 @@
"better-auth": "~1.4.21",
"drizzle-kit": "^0.31.8",
"drizzle-orm": "^0.45.1",
"eslint": "^9.39.2",
"eslint": "^10.0.3",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-svelte": "^3.14.0",
"globals": "^17.3.0",
"eslint-plugin-svelte": "^3.15.2",
"globals": "^17.4.0",
"mdsvex": "^0.12.6",
"playwright": "^1.58.2",
"prettier": "^3.8.1",
Expand All @@ -51,7 +51,7 @@
"svelte-check": "^4.4.2",
"tailwindcss": "^4.1.18",
"typescript": "^5.9.3",
"typescript-eslint": "^8.54.0",
"typescript-eslint": "^8.57.0",
"vite": "^7.3.1",
"vite-plugin-devtools-json": "^1.0.0",
"vitest": "^4.1.0",
Expand Down
6 changes: 2 additions & 4 deletions packages/sv/src/create/templates/demo/src/routes/sverdle/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,20 @@
import { confetti } from '@neoconfetti/svelte';
import { MediaQuery } from 'svelte/reactivity';

import type { ActionData, PageData } from './$types';
import type { PageData } from './$types';

interface Props {
data: PageData;
Copy link
Contributor

@sacrosanctic sacrosanctic Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while, you're at it, wanna update this to PageProps?

form: ActionData;
}
/**
* @typedef {Object} Props
* @property {import('./$types').PageData} data
* @property {import('./$types').ActionData} form
*/

/**
* @type {Props}
*/
let { data, form = $bindable() }: Props = $props();
let { data }: Props = $props();

/** Whether the user prefers reduced motion */
const reducedMotion = new MediaQuery('(prefers-reduced-motion: reduce)');
Expand Down
Loading
Loading