support "mapping extensions" beatmaps#192
Open
digama0 wants to merge 3 commits intosupermedium:masterfrom
Open
support "mapping extensions" beatmaps#192digama0 wants to merge 3 commits intosupermedium:masterfrom
digama0 wants to merge 3 commits intosupermedium:masterfrom
Conversation
dmarcos
reviewed
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some maps like
Shirobon - Into the Zonemake use of theMapping Extensionsadd-on(?), in which_lineIndexand_lineLayerare not in the range 0..3, 0..2 but are instead more than 1000. This would previously cause these maps to break, generating all notes in a line on the left. The explanation of the mapping is given here, which has been copied into this code.I had to remove the indirection through
horizontalPositionsHumanized, because it does not generalize well to notes at fractional positions. Other mappings have been converted to linear functions as appropriate.