fix: check SIWE ExpirationTime independently of NotBefore#2454
Open
oniani1 wants to merge 1 commit intosupabase:masterfrom
Open
fix: check SIWE ExpirationTime independently of NotBefore#2454oniani1 wants to merge 1 commit intosupabase:masterfrom
oniani1 wants to merge 1 commit intosupabase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2453
In
web3GrantEthereum, the expiration check for SIWE messages is gated onNotBefore != nil:Per EIP-4361,
not-beforeandexpiration-timeare independent optional fields. When a SIWE message includes anexpirationTimebut omitsnotBefore, the entire expiration check is skipped and the expired message is accepted.The Solana handler already checks them independently and doesn't have this problem.
The
MaximumValidityDurationfallback is a separate, broader window based onIssuedAt-- it doesn't respect the per-messageExpirationTime. So a message that sets a short expiration would still be accepted for the fullMaximumValidityDuration.The fix removes
parsedMessage.NotBefore != nil &&from the expiration check condition, matching the pattern used in the Solana handler.