Update .cfg files to comply with SU2 v 7.2.1#3
Open
clmurphey wants to merge 3 commits intosu2code:masterfrom
Open
Update .cfg files to comply with SU2 v 7.2.1#3clmurphey wants to merge 3 commits intosu2code:masterfrom
clmurphey wants to merge 3 commits intosu2code:masterfrom
Conversation
- Update `.cfg` files within the `mms` directory to comply with the latest config_template.cfg in https://github.com/su2code/SU2/blob/5655d91d7da192ad0b2a231f9ab5334c2235c10a/config_template.cfg - Update instances each copy of `compute_order_accuracy.py` to comply with Python 3.9 syntax (e.g., print statements)
I have added `time_convergence.py`, a Python script based on `computer_order_of_accuracy.py` [here](https://github.com/su2code/VandV/blob/ad27cdf9391c9077f3ef14949e29c01be428b0d9/mms/fvm_navierstokes/compute_order_of_accuracy.py). This script loops over various different time marching schemes (e.g., `TIME_MARCHING = TIME_STEPPING`, `TIME_MARCHING = DUAL-TIME_STEPPING-1ST_ORDER`, `TIME_MARCHING = DUAL-TIME_STEPPING-2ND_ORDER`) for each of SU2's Navier Stokes Solvers (e.g., `FEM_NAVIER_STOKES` and `NAVIER_STOKES`) using different numerical methods (e.g., DG, JST, ROE+LIM, ROE, ROW+WLS). Each case is evaluated at a different `TIME_STEP` size [1e-6 : 1e-10].
commented out a few plots and rearranged the directory.
pcarruscag
reviewed
Jan 23, 2022
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Wow thank you for the updates @clmurphey, I did not get all notification on this repository, sorry for the delay.
Few questions:
- Can you present this work at one of the developer meetings? Wednesdays at 3pm UK, https://meet.jit.si/SU2_DevMeeting
- I suppose a lot of the new files are created automatically? i.e. the meshes are generated and the .vtu files etc. are produced by SU2, and the new images from python?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
.cfgfiles within themmsdirectory to comply with the latest config_template.cfg in https://github.com/su2code/SU2/blob/5655d91d7da192ad0b2a231f9ab5334c2235c10a/config_template.cfgcompute_order_accuracy.pyto comply with Python 3.9 syntax (e.g., print statements)Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
I am submitting my contribution to the updates.