Support passing external session to sync client#310
Merged
logan-stytch merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Contributor
Author
|
Tagging in @logan-stytch as our resident python expert 😅 TY! |
jlai-stytch
force-pushed
the
jlai/sync_client_session
branch
from
603b081 to
aee16d5
Compare
logan-stytch
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for passing in an external
requests.Sessionto the sync clientThe underlying
SyncClientsupports it already https://github.com/stytchauth/stytch-python/blob/v14.3.0/stytch/core/http/client.py#L40I assume we don't have to do any cleaning up of the session unlike with the async client, since GC should handle it already if I understand correctly?
Motivation
Customer request - they were having issues with idle connection handling and wanted to have better control over this by passing in custom sessions into the sync client
https://app.plain.com/workspace/w_01HAQ5N757DAG0R7JTXZ4MQYKY/thread/th_01KNSVBGVA90H5G93N0AE3XZZH/
Testing