Conversation
stanislaw
force-pushed
the
Stanislaw/update_submodule
branch
from
dea6da9 to
f71c2d1
Compare
WHAT: This synchronizes to the upstream commit: 38cd41c71fbc55b011eb3ddedb14d023d8408a86. Since the last sync, there were several fixes made, especially the issue with empty <p> paragraphs that could result in empty pages printed. The empty <p> paragraphs were reproduced in the input content produced by a commercial tool. Technically, it is not an issue with html2pdf4doc.js per se, but we decided to handle this case anyway. WHY: This helps us to test out the current batch of fixes and continue testing with the improved baseline.
stanislaw
force-pushed
the
Stanislaw/update_submodule
branch
from
f71c2d1 to
26264b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT:
This synchronizes to the upstream commit: 38cd41c71fbc55b011eb3ddedb14d023d8408a86.
Since the last sync, there were several fixes made, especially the issue with empty
paragraphs that could result in empty pages printed.
The empty
paragraphs were reproduced in the input content produced by a commercial tool. Technically, it is not an issue with html2pdf4doc.js per se, but we decided to handle this case anyway.
WHY:
This helps us to test out the current batch of fixes and continue testing with the improved baseline.