Skip to content

feat: add additional_tags support for standardized resource labeling#81

Merged
mitch-hamm merged 4 commits into
masterfrom
mh/standardize-tagging
Apr 29, 2026
Merged

feat: add additional_tags support for standardized resource labeling#81
mitch-hamm merged 4 commits into
masterfrom
mh/standardize-tagging

Conversation

@mitch-hamm
Copy link
Copy Markdown
Contributor

@mitch-hamm mitch-hamm commented Apr 28, 2026

Summary

Adds additional_tags variable support across the GKE cluster module and submodules, enabling consistent GCP label propagation to all provisioned resources.

Root module (/):

  • Added additional_tags variable (map(string), default {})
  • module.gke + module.gke_private: pass cluster_resource_labels = var.additional_tags (labels the GKE cluster resource itself)
  • local.node_pools_labels.all: merged with var.additional_tags (labels all node pool VMs)
  • google_kms_crypto_key.gke_encryption_key: added labels = var.additional_tags

modules/dns-bucket:

  • Added additional_tags variable
  • Applied labels = var.additional_tags to google_storage_bucket (velero, tiered_storage, loki) and google_dns_managed_zone

modules/vpc:

  • Added additional_tags variable
  • Applied network_labels = var.additional_tags to module.network and labels = var.additional_tags to module.cloud_router

Use case

The CloudEnvironment reconciler sets cloud.streamnative.io/cloudenvironment-name and related labels via additionalTags in the Argo workflow TF vars. This change ensures those labels are propagated to GKE clusters, node pools, KMS keys, GCS buckets, DNS zones, VPC networks, and Cloud Routers.

Test plan

  • Verify terraform plan shows label changes on existing resources (no destructive changes)
  • Confirm additional_tags = {} (default) produces no diff on existing deployments
  • Validate labels appear on GKE cluster, node pools, and GCS buckets after apply

@mitch-hamm mitch-hamm requested a review from a team as a code owner April 28, 2026 00:17
@mitch-hamm mitch-hamm changed the title feat: Standardize additional tagging feat: add additional_tags support for standardized resource labeling Apr 28, 2026
@mitch-hamm mitch-hamm merged commit bee40a5 into master Apr 29, 2026
6 checks passed
@mitch-hamm mitch-hamm deleted the mh/standardize-tagging branch April 29, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants