Open
Conversation
summeroff
force-pushed
the
remove_const_enums
branch
from
9af8599 to
a6cfe98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package exports
const enums instead of regularenums. References to aconst enumare inlined at compile time, so there is no runtime object associated with the enum. Most modern javascript bundlers compile typescript withisolatedModules: truewhich means that type checking doesn't happen across module boundaries, and therefore the enums cannot be inlined.Removing the
constkeyword from these enums means that the compiled javascript build object formodule.tswill contain runtime objects that can be used to access enum values.