fix(channels_sv2): migrate ShareAccounting from f64 to u64#2116
fix(channels_sv2): migrate ShareAccounting from f64 to u64#2116Alkamal01 wants to merge 16 commits intostratum-mining:mainfrom
Conversation
Refactor share tracking fields to use u64 instead of f64 to avoid precision loss when accumulating shares. Fixes stratum-mining#2092
Alkamal01
changed the title
Alkamal01
changed the title
Shourya742
left a comment
Shourya742
left a comment
There was a problem hiding this comment.
It seems like this might have been generated with AI. Please be mindful of the reviewer’s time and effort
| /// _mining.extranonce.subscribe()_ | ||
| /// Indicates to the server that the client supports the mining.set_extranonce method. | ||
| /// https://en.bitcoin.it/wiki/BIP_0310 | ||
| /// <https://en.bitcoin.it/wiki/BIP_0310> |
| @@ -1,4 +1,4 @@ | |||
| //! https://www.jsonrpc.org/specification#response_object | |||
| //! <https://www.jsonrpc.org/specification#response_object> | |||
| //! [<https://docs.google.com/document/d/17zHy1SUlhgtCMbypO8cHgpWH73V5iUQKk_0rWvMqSNs/edit?hl=en_US#>] | ||
| //! [<https://braiins.com/stratum-v1/docs>] | ||
| //! [<https://en.bitcoin.it/wiki/Stratum_mining_protocol>] | ||
| //! [<https://en.bitcoin.it/wiki/BIP_0310>] | ||
| //! [<https://docs.google.com/spreadsheets/d/1z8a3S9gFkS8NGhBCxOMUDqs7h9SQltz8-VX3KPHk7Jw/edit#gid=0>] |
| "integration-test-framework", | ||
| "fuzz" | ||
| "fuzz", | ||
| "sv2-apps" |
|
Hey @Shourya742, fair questions, both were added for CI reasons. |
|
This PR is changing many things which are not related to the original issue, it has 16 commits for such a simple task, and can definitely lead to time loss for reviewers. As agreed during last PR Review Club call, @plebhash will deal with this with a clean PR during this milestone. |
3 participants
Refactor share tracking fields to use u64 instead of f64 to avoid precision loss when accumulating shares.
Fixes #2092
companion stratum-mining/sv2-apps#332