Skip to content

Ondra fix reset bugs #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrej-lukas merged 3 commits into from
Mar 10, 2026
Merged

Ondra fix reset bugs #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2630f
Report that WhiteBox NSG does not support ip re-mapping
ondrej-lukas Mar 10, 2026
6f890fc
Correctly check for blocked reset if agent disconnects
ondrej-lukas Mar 10, 2026
a2bde5e
add default value (copied from NSG)
ondrej-lukas Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netsecgame/game/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ async def _remove_agent_from_game(self, agent_addr):
# remove agent from reset requests
agent_info["reset_request"] = self._reset_requests.pop(agent_addr)
# check if this agent was not preventing reset
if any(self._reset_requests.values()):
if all(self._reset_requests.values()):
self._reset_event.set()
agent_info["episode_end"] = self._episode_ends.pop(agent_addr)
#check if this agent was not preventing episode end
Expand Down
7 changes: 7 additions & 0 deletions netsecgame/game/worlds/WhiteBoxNetSecGame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import logging
import os
import json
import warnings
from pathlib import Path
from netsecgame.utils.utils import get_logging_level
from netsecgame.game_components import Action, ActionType
Expand Down Expand Up @@ -126,6 +127,12 @@ def _generate_all_actions(self)-> list[Action]:
def _create_state_from_view(self, view, add_neighboring_nets = True):
return super()._create_state_from_view(view, add_neighboring_nets=add_neighboring_nets)

def _dynamic_ip_change(self, max_attempts:int=10)->None:
warnings.warn("Dynamic IP change is not supported for WhiteBoxNetSecGame.", UserWarning)
self.logger.warning("Dynamic IP change is not supported for WhiteBoxNetSecGame.")
return None


if __name__ == "__main__":
parser = argparse.ArgumentParser(
description="NetSecGame Coordinator Server Author: Ondrej Lukas ondrej.lukas@aic.fel.cvut.cz",
Expand Down