Open
Conversation
These methods aren't applicable to this class
574f9f8 to
113fc17
Compare
dpanta94
requested changes
Apr 15, 2025
dpanta94
approved these changes
Apr 15, 2025
Camwyn
suggested changes
Apr 17, 2025
Contributor
Camwyn
left a comment
There was a problem hiding this comment.
Some docblock tweaks.
Overall looks good.
Agree with Dimi on the new static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
VendorAssetclass for use with vendor scripts. The specific uses case is when handling a 3rd-party asset and registering a CDN URL for the asset instead of a local URL.Notable changes:
VendorAssetclass as an extension of theAssetclass.wpunittest suite to test various aspects ofVendorAsset.Assetclass.