Skip to content

SEP-0051: update JSON example.#1889

Open
overcat wants to merge 1 commit intostellar:masterfrom
overcat:patch-5
Open

SEP-0051: update JSON example.#1889
overcat wants to merge 1 commit intostellar:masterfrom
overcat:patch-5

Conversation

@overcat
Copy link
Contributor

@overcat overcat commented Mar 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 07:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SEP-0051 XDR-JSON TransactionEnvelope example to better reflect correct JSON field types/names for Soroban-era transactions.

Changes:

  • Represent seq_num as a JSON string (instead of a number) in the example.
  • Rename the example resource field read_bytes to disk_read_bytes.
  • Represent resource_fee as a JSON string (instead of a number) in the example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants