Auto-build contracts when WASM not provided in deploy/upload. #2378

fnando · 2026-01-30T01:27:15Z

What

Auto-build contracts when WASM file is not provided in stellar contract deploy and stellar contract upload commands.

stellar contract deploy automatically builds the project when neither --wasm nor --wasm-hash is provided. Adds optional --package flag to specify which package to build in multi-package workspaces.
stellar contract upload automatically builds the project when --wasm is omitted. Adds optional --package flag to specify which package to build in multi-package workspaces.

# Deploy without specifying WASM (auto-builds)
stellar contract deploy

# Deploy with specific package in workspace
stellar contract deploy --package my-contract

# Upload without specifying WASM (auto-builds)
stellar contract upload

# Upload with specific package in workspace
stellar contract upload --package my-contract

When deploying multiple contracts, aliases matching the package name will be used and automatically defined.

Why

Closes #2047.

Known limitations

N/A

leighmcculloch

Looks like the new code would benefit from tests, if it's not awkward to add integration tests for that.

One suggestion inline, but it is easily done as an improvement separately and doesn't need to block.

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

cmd/soroban-cli/src/commands/contract/build.rs

FULL_HELP_DOCS.md

Copilot

Pull request overview

This PR adds “auto-build” behavior to contract deployment flows, so users can run stellar contract deploy / stellar contract upload without manually providing a WASM path when working inside a Cargo contract project/workspace.

Changes:

contract deploy: makes --wasm/--wasm-hash optional and auto-builds contracts when omitted; adds --package to select a specific workspace package; supports deploying multiple built contracts with derived aliases.
contract upload (and deprecated install): makes --wasm optional and auto-builds when omitted; adds --package to select a specific workspace package; supports uploading multiple built artifacts.
contract build: refactored to return a list of built WASM artifacts (name + path) for reuse by deploy/upload, and docs regenerated accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
cmd/soroban-cli/src/commands/contract/upload.rs	Makes `--wasm` optional, auto-builds when omitted, and uploads one or many built WASMs.
cmd/soroban-cli/src/commands/contract/mod.rs	Adjusts dispatch to the updated `contract build` return type.
cmd/soroban-cli/src/commands/contract/deploy/wasm.rs	Makes WASM inputs optional, auto-builds when omitted, supports multi-contract deploy and derived aliases.
cmd/soroban-cli/src/commands/contract/build.rs	Returns built artifact metadata (`BuiltContract`) so other commands can auto-build and consume outputs.
FULL_HELP_DOCS.md	Updates CLI help docs to reflect new optional WASM flags and `--package` build options.

FULL_HELP_DOCS.md

cmd/soroban-cli/src/commands/contract/upload.rs

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

cmd/soroban-cli/src/commands/contract/upload.rs

cmd/crates/soroban-test/tests/it/integration/auto_build.rs

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot · 2026-01-30T18:49:34Z

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

    pub async fn run(&self, global_args: &global::Args) -> Result<(), Error> {
-        let res = self
-            .execute(&self.config, global_args.quiet, global_args.no_cache)
+        if self.build_only && self.wasm.is_none() && self.wasm_hash.is_none() {


--build-only is currently allowed when --wasm-hash is provided (the early check only rejects when both --wasm and --wasm-hash are missing), but execute() later requires a local WASM file for --build-only and will error. This results in confusing behavior/error messages for stellar contract deploy --wasm-hash ... --build-only. Consider either (a) rejecting --build-only unless --wasm is provided, or (b) implementing true build-only support for --wasm-hash (likely only when no constructor args, or by allowing fetching spec in build-only).

Suggested change

if self.build_only && self.wasm.is_none() && self.wasm_hash.is_none() {

if self.build_only && self.wasm.is_none() {

Copilot · 2026-01-30T18:49:35Z

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

+        let contracts = build_cmd.run(global_args).map_err(|e| match e {
+            build::Error::Metadata(_) => Error::NotInCargoProject,
+            other => other.into(),
+        })?;


build::Error::Metadata(_) is mapped to NotInCargoProject, but build::Error::Metadata wraps any cargo_metadata::Error (invalid Cargo.toml, cargo failures, etc.), not just “no Cargo.toml found”. This can surface a misleading error message. Consider detecting the “no manifest / no Cargo.toml” case explicitly (e.g., by checking for a Cargo.toml in the cwd/ancestors or inspecting the cargo_metadata error) and otherwise returning the original build/metadata error.

Copilot · 2026-01-30T18:49:35Z

cmd/soroban-cli/src/commands/contract/upload.rs

+            let contracts = build_cmd.run(global_args).map_err(|e| match e {
+                build::Error::Metadata(_) => Error::NotInCargoProject,
+                other => other.into(),
+            })?;


build::Error::Metadata(_) is mapped to NotInCargoProject, but build::Error::Metadata wraps any cargo_metadata::Error (invalid Cargo.toml, cargo failures, etc.), not only the “no Cargo.toml found” case. This can produce a misleading NotInCargoProject message when the workspace exists but cargo_metadata fails for another reason. Consider distinguishing “no Cargo.toml” from other metadata failures before converting the error.

Auto-build contracts when WASM not provided in deploy/upload.

a210120

fnando requested a review from a team as a code owner January 30, 2026 01:27

Copilot AI review requested due to automatic review settings January 30, 2026 01:27

github-project-automation bot added this to DevX Jan 30, 2026

github-project-automation bot moved this to Backlog (Not Ready) in DevX Jan 30, 2026

fnando self-assigned this Jan 30, 2026

Copilot started reviewing on behalf of fnando January 30, 2026 01:27 View session

fnando moved this from Backlog (Not Ready) to In Progress in DevX Jan 30, 2026

fnando requested review from leighmcculloch and mootz12 January 30, 2026 01:28

leighmcculloch approved these changes Jan 30, 2026

View reviewed changes

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs Show resolved Hide resolved

cmd/soroban-cli/src/commands/contract/build.rs Show resolved Hide resolved

FULL_HELP_DOCS.md Show resolved Hide resolved

Copilot AI reviewed Jan 30, 2026

View reviewed changes

fnando added 3 commits January 29, 2026 18:24

Add tests.

620c336

Add support for meta/optimization.

50fec44

Address copilot feedback.

7ea2b1f

fnando requested a review from Copilot January 30, 2026 02:47

Copilot started reviewing on behalf of fnando January 30, 2026 02:47 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

mootz12 approved these changes Jan 30, 2026

View reviewed changes

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs Show resolved Hide resolved

Address copilot feedback.

caea9f8

fnando requested a review from Copilot January 30, 2026 18:18

Copilot started reviewing on behalf of fnando January 30, 2026 18:19 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs Outdated Show resolved Hide resolved

Fix checks.

1eece8e

fnando requested a review from Copilot January 30, 2026 18:36

Copilot started reviewing on behalf of fnando January 30, 2026 18:36 View session

Prevent --package from being used with --wasm/--wasm-hash.

d9d05c2

fnando enabled auto-merge (squash) January 30, 2026 18:44

fnando moved this from In Progress to Needs Review in DevX Jan 30, 2026

fnando merged commit cc816f5 into main Jan 30, 2026
29 checks passed

fnando deleted the deploy-all branch January 30, 2026 18:49

github-project-automation bot moved this from Needs Review to Done in DevX Jan 30, 2026

Copilot AI reviewed Jan 30, 2026

View reviewed changes

	if self.build_only && self.wasm.is_none() && self.wasm_hash.is_none() {
	if self.build_only && self.wasm.is_none() {

Auto-build contracts when WASM not provided in deploy/upload. #2378

Auto-build contracts when WASM not provided in deploy/upload. #2378

Conversation

fnando commented Jan 30, 2026

What

Why

Known limitations

Uh oh!

leighmcculloch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants