add support for left and right aligned buttons#73
Open
brendanlensink wants to merge 2 commits intomainfrom
Open
add support for left and right aligned buttons#73brendanlensink wants to merge 2 commits intomainfrom
brendanlensink wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has come up a couple times where I've wanted a button that fills its parent view but has the text left aligned, but we don't really have a good way of supporting it.
This PR adds that option by introducing a new
contentHorizontalAlignmentparameter that defaults to center but allows users to set it to trailing or leading to move the content to the respective edge.It also slighly changes the default behaviour for the
horizontalContentPaddingparameter to fit with this. Since the default was previously nil in all cases, but if you set leading/trailing alignment that would mean the text is right up against the edge of the button which looks obviously wrong.