Fix release workflow build failures#137
Open
DePasqualeOrg wants to merge 5 commits intostasel:latestfrom
Open
Conversation
Query the Chromium Dashboard for the current stable milestone instead of always targeting latestRelease + 1. Exit with an error if the milestone cannot be determined. Use GITHUB_REPOSITORY env var for GitHub API write calls so the script works on forks as well as upstream.
fd6bfdd to
02f8ed4
Compare
Owner
|
Hi @DePasqualeOrg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly release workflow has been failing since late October 2025. There were two independent problems:
1. Release script stuck on outdated milestones
getNextRelease()always targetslatestRelease + 1, so after M141 it kept trying to build M142 every week. M142's buildtools were incompatible with the CI runner, so it failed repeatedly while Chromium stable advanced to M144.The script now queries the Chromium Dashboard
fetch_milestonesAPI for the current stable milestone and skips ahead to it. If the API call fails, the script exits with an error.2. Xcode SDK incompatibility
WebRTC milestone branches ship with frozen Chromium buildtools that only support the Xcode/SDK version current at the time of the branch cut. As GitHub Actions runner images update, newer Xcode versions introduce SDK framework splits (e.g.
DarwinFoundation,UIUtilities) that break the build.Both workflows now pin Xcode 16.1 (the version expected by current buildtools — see
build/mac_toolchain.pyin the WebRTC source). This needs to be updated when future milestones require a newer Xcode. The manual build workflow also uploads the build output as a zip to preserve macOS framework symlinks.Other minor changes:
GITHUB_REPOSITORYenv var for all GitHub API calls instead of hardcodingstasel/WebRTC. This makes the script work when run from forks.X.Y.Zversion instead of onlyX.0.0. Patch releases (e.g.144.0.1) would break the URL update inPackage.swift.Testing
The workflow ran successfully and produced releases of the latest versions on DePasqualeOrg/WebRTC. The x.0.1 patch versions have been patched for the missing header issue mentioned below, so they work on iOS and macOS.
Note: Milestones M141–M144 have a separate issue where framework headers aren't copied into the bundle (webrtc:450130875), which causes build failures in Xcode. CL 424441 fixed this for iOS but not for macOS — the macOS framework is still missing headers as of M145. The upstream fix adds
create_bracket_include_headersas a dependency formac_framework_bundlebut doesn't copy the generated headers into the bundle'sVersions/A/Headers/directory.