Add timing info to additional services#3393
Open
0xr0bert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3376
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Added timing information ("Elapsed Time") to ADVI, Optimization (BFGS, L-BFGS, Newton), and Laplace Approximation Services
Intended Effect
Ensures that all major Stan services consistently report their elapsed execution time in both the console and as comments in the CSV output.
How to Verify
New test cases have been added to the following files to assert the presence of timing information:
Side Effects
No unintended side effects.
Documentation
No external documentation updates are required as this aligns with the existing behavior of other Stan services.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: