-
Notifications
You must be signed in to change notification settings - Fork 48
Onboard logs service access token #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-token' into feat/onboard-logs-service-access-token
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| description = "Example description" | ||
| } | ||
|
|
||
| # Only use the import statement, if you want to import an existing logs instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Only use the import statement, if you want to import an existing logs instance | |
| # Only use the import statement, if you want to import an existing logs access token |
Please add here also an hint, that the actual access token will not be imported because it can be only read during the creation and that probably lifetime needs to be added to ignore_changes.
Similar like for example in the server resource:
terraform-provider-stackit/docs/resources/server.md
Lines 381 to 388 in d772e2e
| # Only use the import statement, if you want to import an existing server | |
| # Note: There will be a conflict which needs to be resolved manually. | |
| # Must set a configuration value for the boot_volume.source_type and boot_volume.source_id attribute as the provider has marked it as required. | |
| # Since those attributes are not fetched in general from the API call, after adding them this would replace your server resource after an terraform apply. | |
| # In order to prevent this you need to add: | |
| # lifecycle { | |
| # ignore_changes = [ boot_volume ] | |
| # } |
Description
relates to STACKITTPR-449
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)