Skip to content

Conversation

@GokceGK
Copy link
Contributor

@GokceGK GokceGK commented Jan 28, 2026

Description

relates to STACKITTPR-449

Checklist

  • [X ] Issue was linked above
  • [X ] Code format was applied: make fmt
  • [X ] Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • [X ] Unit tests got implemented or updated
  • [ X] Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK GokceGK requested a review from a team as a code owner January 28, 2026 18:19
@GokceGK GokceGK marked this pull request as draft January 28, 2026 18:19
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.48% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/accesstoken 23.24% (+23.24%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/accesstoken/datasource.go 35.14% (+35.14%) 74 (+74) 26 (+26) 48 (+48) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/accesstoken/resource.go 19.05% (+19.05%) 210 (+210) 40 (+40) 170 (+170) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.48% (ø) 135 2 133

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/accesstoken/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/accesstoken/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/logs_acc_test.go

description = "Example description"
}

# Only use the import statement, if you want to import an existing logs instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Only use the import statement, if you want to import an existing logs instance
# Only use the import statement, if you want to import an existing logs access token

Please add here also an hint, that the actual access token will not be imported because it can be only read during the creation and that probably lifetime needs to be added to ignore_changes.
Similar like for example in the server resource:

# Only use the import statement, if you want to import an existing server
# Note: There will be a conflict which needs to be resolved manually.
# Must set a configuration value for the boot_volume.source_type and boot_volume.source_id attribute as the provider has marked it as required.
# Since those attributes are not fetched in general from the API call, after adding them this would replace your server resource after an terraform apply.
# In order to prevent this you need to add:
# lifecycle {
# ignore_changes = [ boot_volume ]
# }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants