Skip to content

feat(ci): migrate to golangci-lint v2#7302

Open
rubenhoenle wants to merge 1 commit into
mainfrom
feat/golang-ci-lint-v2
Open

feat(ci): migrate to golangci-lint v2#7302
rubenhoenle wants to merge 1 commit into
mainfrom
feat/golang-ci-lint-v2

Conversation

@rubenhoenle
Copy link
Copy Markdown
Member

Description

relates to #7279

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner May 18, 2026 10:58
RefreshToken: refreshToken,
}
responseBody, err := json.Marshal(responseBodyStruct)
responseBody, err := json.Marshal(responseBodyStruct) //nolint:gosec // G117: access_token is a standard field name
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd disable this gosec rule, a lot of false positives and I'd expect no true positive in our code.

Comment thread core/clients/key_flow.go

payload := strings.NewReader(body.Encode())
req, err := http.NewRequest(http.MethodPost, c.config.TokenUrl, payload)
req, err := http.NewRequest(http.MethodPost, c.config.TokenUrl, payload) //nolint:gosec // G704: Tainted URL is expected here
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also disable this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants